Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move Enhanced navigation out of feature preview #33529

Draft
wants to merge 25 commits into
base: develop
Choose a base branch
from
Draft

feat: move Enhanced navigation out of feature preview #33529

wants to merge 25 commits into from
+1,491 −10,476

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Oct 10, 2024 •
edited by jira bot
Loading

Proposed changes (including videos or screenshots)

  • move Enhanced navigation away from feature preview and make it official SIDE-210
    • delete duplicated Header
    • delete duplicated NavBar
    • delete duplicated sidebar
  • adjust tests SIDE-181

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 10, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e7e9217

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@juliajforesti juliajforesti changed the title feat: Enhanced navigation feat: move Enhanced navigation out of feature preview Oct 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33529/
on branch gh-pages at 2024-12-09 20:15 UTC

@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (f11efb4) to head (e7e9217).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33529   +/-   ##
========================================
  Coverage    75.79%   75.79%           
========================================
  Files          511      511           
  Lines        22132    22132           
  Branches      5394     5394           
========================================
  Hits         16775    16775           
  Misses        4709     4709           
  Partials       648      648
Flag Coverage Δ
unit 75.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti force-pushed the feat/enhanced-nav branch 2 times, most recently from 3209752 to 355f259 Compare October 11, 2024 18:10
@juliajforesti juliajforesti force-pushed the feat/enhanced-nav branch 3 times, most recently from b2a72c9 to d4fb380 Compare December 10, 2024 21:56
@juliajforesti
feat: delete navbar and rename NavBarV2 to navbar
ca69db7
@juliajforesti
feat: delete client/sidebar and rename client/sidebarv2 to `clien…
1405257 
…t/sidebar`
@juliajforesti
feat: delete client/views/room/Header and rename `client/views/room…
f846352 
…/HeaderV2` to `client/views/room/Header`
@juliajforesti
chore: adjust imports
69ad158
@juliajforesti
feat: delete RoomBody and LayoutWithSidebar and rename v2
a1a835d
@juliajforesti
chore: adjust imports
f487bfb
@juliajforesti
fix: add missing global declaration
9e7f029
@juliajforesti
test: deprecate home-sidenav fragments. moved and refactored to `si…
b0516e2 
…debar`, `navbar` and `create-room-modal`
@juliajforesti
test: add new fragments to page-objects
3bc4309
@juliajforesti
fix: CreateDirectMessage a11y form to be located by the test fragment
ef7f63e
@juliajforesti
test: replace test fragments
f743ebd
@juliajforesti
test: replace test fragments
11e37ad
@juliajforesti
test: replace omnichannel test fragments
bb606f1
@juliajforesti
test: improve mark-unread consistency
1a34c85
@juliajforesti
test: channel-management
53eddf6
@juliajforesti
test: team-management
d37ad91
@juliajforesti
test: e2e-encryption
e41fb9f
@juliajforesti
feat: use only ContextualbarV2 in client/components/Contextualbar
bc316d6
@juliajforesti
feat: use only HeaderV2 in client/components/Header
284ea6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@juliajforesti